SoFi’s milestone underscores its knack for attracting a young, diverse user base, but its future isn’t all sunshine